[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/plugins/textshape
From:       Elvis Stansvik <elvstone () gmail ! com>
Date:       2009-07-19 13:47:36
Message-ID: 751a4f870907190647t34925436r7405c01d4c44e615 () mail ! gmail ! com
[Download RAW message or body]

2009/7/19 Inge Wallin <inge@lysator.liu.se>:
> On Saturday 18 July 2009 23:36:17 Elvis Stansvik wrote:
>> SVN commit 998991 by astan:
>>
>> Doing some detailed commenting of this code, for my own and
>> Casper's sanity ;)
>>
>>  M  +54 -10    Layout.cpp
>>
>>
>> --- trunk/koffice/plugins/textshape/Layout.cpp #998990:998991
>> @@ -329,43 +329,87 @@
>>      else
>>          m_isRtl =  dir == KoText::RightLeftTopBottom || dir ==
>> KoText::PerhapsRightLeftTopBottom;
>>
>> -    // tables.
>> +    // Check if we are inside a table.
>>      QTextCursor tableFinder(m_block);
>>      QTextTable *table = tableFinder.currentTable();
>>      if (table) {
>> +        /*
>> +         * The current table is different from the one that is currently
>> +         * set on the table layout, which means we have entered a table.
>> +         */
>
> Hmm, I must admit that I'm not 100% sure, but I seem to remember that our
> style guide says that even multi line comments should use // instead of /* */.

Ah, I'll make sure to fix those and some others up then.

Elvis

>
>        -Inge
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic