--===============0031600712==
Content-Type: multipart/alternative; boundary=000e0cd29ed879dc32046ee710e8

--000e0cd29ed879dc32046ee710e8
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On Fri, Jul 17, 2009 at 2:41 PM, Sven Langkamp <sven.langkamp@gmail.com>wrote:

> On Fri, Jul 17, 2009 at 1:48 PM, Thomas Zander <zander@kde.org> wrote:
>
>> On Friday 03 July 2009 03:43:16 Sven Langkamp wrote:
>> > Hi,
>> >
>> > in the ongoing plugfest testing an issue where text appeared with
>> underline
>> > and line-through in OOo has been found.
>> > For details see
>> >
>> http://plugtest.opendocsociety.org/doku.php?id=scenarios:20090623:presentat
>> >ion-placeholder
>> >
>> > I found out that the character style is loads with line type single if
>> the
>> > specified line type is empty and the style is "none"
>> > I have attached a patch to change it to load as NoLineType. The ODF spec
>> is
>> > a bit confusing at this point, so I'm posting it for review.
>>
>> Sorry for taking so long to reply...
>>
>> I think the patch is almost correct but I'm worried it doesn't cover all
>> cases. Specifically the 'if()' directly following the one you modified
>> might set
>> your style to 'solid' instead of none.
>> Can you test the attached patch to solve the issue you had too? I think it
>> is
>> a tad more complete.
>>
>
>
> -    if (fixedType.isEmpty() && !fixedStyle.isEmpty())
> +    if (fixedType.isEmpty() && !fixedStyle.isEmpty() && fixedStyle !=
> "none")
>          fixedType = "single";
>
>
> -    if (fixedType.isEmpty() && !fixedStyle.isEmpty())
> +    if (fixedStyle == "none")
> +        fixedType.clear();
> +    else if (fixedType.isEmpty() && !fixedStyle.isEmpty())
>          fixedType = "single";
>
> Isn't your patch doing the exact opposite of my patch? I guess with need a
> unittest anyway.
>

Ah no, I was wrong here. Both patches do the same. Line type has the value
KoCharacterStyle::NoLineType by default so that case doesn't have to be
covered.

--000e0cd29ed879dc32046ee710e8
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Fri, Jul 17, 2009 at 2:41 PM, Sven La=
ngkamp <span dir=3D"ltr">&lt;<a href=3D"mailto:sven.langkamp@gmail.com">sve=
n.langkamp@gmail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_qu=
ote" style=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0p=
t 0.8ex; padding-left: 1ex;">
<div><div></div><div class=3D"h5"><div class=3D"gmail_quote">On Fri, Jul 17=
, 2009 at 1:48 PM, Thomas Zander <span dir=3D"ltr">&lt;<a href=3D"mailto:za=
nder@kde.org" target=3D"_blank">zander@kde.org</a>&gt;</span> wrote:<br><bl=
ockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, 204=
, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

On Friday 03 July 2009 03:43:16 Sven Langkamp wrote:<br>
&gt; Hi,<br>
&gt;<br>
&gt; in the ongoing plugfest testing an issue where text appeared with unde=
rline<br>
&gt; and line-through in OOo has been found.<br>
&gt; For details see<br>
&gt; <a href=3D"http://plugtest.opendocsociety.org/doku.php?id=3Dscenarios:=
20090623:presentat" target=3D"_blank">http://plugtest.opendocsociety.org/do=
ku.php?id=3Dscenarios:20090623:presentat</a><br>
&gt;ion-placeholder<br>
&gt;<br>
&gt; I found out that the character style is loads with line type single if=
 the<br>
&gt; specified line type is empty and the style is &quot;none&quot;<br>
&gt; I have attached a patch to change it to load as NoLineType. The ODF sp=
ec is<br>
&gt; a bit confusing at this point, so I&#39;m posting it for review.<br>
<br>
Sorry for taking so long to reply...<br>
<br>
I think the patch is almost correct but I&#39;m worried it doesn&#39;t cove=
r all<br>
cases. Specifically the &#39;if()&#39; directly following the one you modif=
ied might set<br>
your style to &#39;solid&#39; instead of none.<br>
Can you test the attached patch to solve the issue you had too? I think it =
is<br>
a tad more complete.<br>
</blockquote><div><br><br></div></div></div></div>-=A0=A0=A0 if (fixedType.=
isEmpty() &amp;&amp; !fixedStyle.isEmpty())<br>+=A0=A0=A0 if (fixedType.isE=
mpty() &amp;&amp; !fixedStyle.isEmpty() &amp;&amp; fixedStyle !=3D &quot;no=
ne&quot;)<br>
=A0=A0=A0=A0=A0=A0=A0=A0 fixedType =3D &quot;single&quot;;<br>
<br><br>-=A0=A0=A0 if (fixedType.isEmpty() &amp;&amp; !fixedStyle.isEmpty()=
)<br>+=A0=A0=A0 if (fixedStyle =3D=3D &quot;none&quot;)<br>+=A0=A0=A0=A0=A0=
=A0=A0 fixedType.clear();<br>+=A0=A0=A0 else if (fixedType.isEmpty() &amp;&=
amp; !fixedStyle.isEmpty())<br>
=A0=A0=A0=A0=A0=A0=A0=A0 fixedType =3D &quot;single&quot;;<br>
<br>Isn&#39;t your patch doing the exact opposite of my patch? I guess with=
 need a unittest anyway.<br>
</blockquote></div><br>Ah no, I was wrong here. Both patches do the same. L=
ine type has the value KoCharacterStyle::NoLineType by default so that case=
 doesn&#39;t have to be covered. <br>

--000e0cd29ed879dc32046ee710e8--

--===============0031600712==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============0031600712==--