[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Improve the toolbox layout
From:       "Peter Simonsson" <peter.simonsson () gmail ! com>
Date:       2009-07-14 12:46:48
Message-ID: 20090714124648.27430.18834 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/782/
-----------------------------------------------------------

(Updated 2009-07-14 12:46:48.436579)


Review request for KOffice.


Changes
-------

Updated the diff to the new libs dir layout.
Removed the dockarea hack as it seems to work as expected now... must have had a bad version of \
Qt for some reason. This patch also allows a single row of icons in horizontal mode.


Summary
-------

Two parts to this diff:
* Simplify the layout algo for the toolbox. The current approach just breaks to easily, see for \
example the default layout of kpresenter. The new algorithm uses a different orientation \
                depending on where the toolbox is docked, this takes us to the second part of \
                the diff...
* Save the area the dockwidget is docked in to work around the fact that Qt always reports the \
default area on start up even if the dockwidget is saved in another area.


Diffs (updated)
-----

  trunk/koffice/libs/main/KoToolBox.cpp 996242 
  trunk/koffice/libs/main/KoToolBox_p.h 996242 

Diff: http://reviewboard.kde.org/r/782/diff


Testing
-------


Thanks,

Peter

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]