[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fixed bugs in thumbnail creation mechanism
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-07-12 13:38:49
Message-ID: 20090712133849.18332.5071 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/990/#review1550
-----------------------------------------------------------


I remember having had trouble with the exactbounds computation and adding that extra \
row column solved the problem. Not sure why anymore... But in general, reading a from \
a paint device should never create new tiles!

On the filter thing, I think it grew historically like this -- I'm not sure about the \
reasns anymore, but maybe Cyrille knows?

- Boudewijn


On 2009-07-12 07:36:09, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/990/
> -----------------------------------------------------------
> 
> (Updated 2009-07-12 07:36:09)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> There is a bug in thumbnails in filters dialog. If you open it and look at 'Invert' \
> thumbnail thoroughly, you'll see that it's thumb is quite higher than others. That \
> is so because filters applied to thumbs inside constant rect (100,100) [1]. \
> 'Invert' filter inverts defaultPixel and after that KisPaintDevice::exactBounds \
> won't work well, because there is no more defaultPixel in thumbnail. This bug is \
> fixed in this patch. 
> Alongside with this bug, there is a bug in KisPaintDevice::exactBounds. In cycles \
> of calculating right and bottom bounds, iterator reads one column/row more than \
> needed every time(!) [2]. This bug is not seen much in old tile engine, as reading \
> of unallocated areas was not causing any changes in internals of engine. But in new \
> one extent is extended by one tile to the right and bottom every time exactBounds() \
> called. This is fixed too. 
> And the last chunk - fix in KisPaintDevice::createThumbnailDevice(). Thumbnail \
> created only for actual image - not it's extent. 
> 
> [1] ui/kis_filters_model.cc:170
> [2] image/kis_paint_device.cc:251 and image/kis_paint_device.cc:287
> 
> 
> Diffs
> -----
> 
> trunk/koffice/krita/image/kis_paint_device.cc 995043 
> trunk/koffice/krita/ui/kis_filters_model.cc 995043 
> 
> Diff: http://reviewboard.kde.org/r/990/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]