[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: koffice/plugins/textshape/tests
From: Elvis Stansvik <elvstone () gmail ! com>
Date: 2009-07-04 23:37:24
Message-ID: 751a4f870907041637m4cacb472v1a856d947348d82c () mail ! gmail ! com
[Download RAW message or body]
2009/7/5 Elvis Stansvik <elvstone@gmail.com>:
> Hi Thomas,
>
> I think your fix for bug #159259 in r991146 broke
> TestDocumentLayout::testBorderData():
>
> FAIL! : TestDocumentLayout::testBorderData() Compared values are not
> the same
> Actual (border->rect()): QRectF(0,24.4 188x38.8) (bottomright
> 188,63.2)
> Expected (QRectF(0, 24.4, 200, 38.8)): QRectF(0,24.4 200x38.8)
> (bottomright 200,63.2)
> Loc: [/home/astan/kde/src/koffice/plugins/textshape/tests/TestDocumentLayout.cpp(757)]
>
> First I thought it was me :) Can you confirm that this is a correct
> fix of the test? It's 200 minus 12 pt for the list marker, so 188 pt
Or rather, the list indent.
*zzz*.
> is correct, right?
>
> Hope Gran Canaria is nice!
>
> Elvis
>
> 2009/7/5 Elvis Stansvik <elvstone@gmail.com>:
> > SVN commit 991466 by astan:
> >
> > Correct the testBorderData() test after the fix of bug #159259 in
> > r991146 broke it.
> >
> > CCMAIL:koffice-devel@kde.org
> >
> > M +2 -2 TestDocumentLayout.cpp
> >
> >
> > --- trunk/koffice/plugins/textshape/tests/TestDocumentLayout.cpp \
> > #991465:991466 @@ -754,7 +754,7 @@
> > // * two paragraphs share a border
> > // * The top indent (of all parags) does not have a border
> > // * The left border is left of the counter
> > - QCOMPARE(border->rect(), QRectF(0, 24.4, 200, 38.8));
> > + QCOMPARE(border->rect(), QRectF(0, 24.4, 188, 38.8));
> >
> > style.setBottomMargin(5);
> > // manually reapply and relayout to force immediate reaction.
> > @@ -770,7 +770,7 @@
> > // The tested here is
> > // * the bottom border of the last parag is directly under the text. \
> > (so similar to rule 2) // This means that the height is the prev 38.8 + \
> > the bottom of the top parag: 5pt = 43.8pt
> > - QCOMPARE(border->rect(), QRectF(0, 24.4, 200, 43.8));
> > + QCOMPARE(border->rect(), QRectF(0, 24.4, 188, 43.8));
> >
> > QCOMPARE(data->counterPosition(), QPointF(3, 24.4));
> >
> > _______________________________________________
> > koffice-devel mailing list
> > koffice-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/koffice-devel
> >
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic