From koffice-devel  Fri Jul 03 11:19:59 2009
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: Fri, 03 Jul 2009 11:19:59 +0000
To: koffice-devel
Subject: Re: Review Request: Fix saving/loading presets for
Message-Id: <20090703111959.8753.40429 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=124662007325612


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/929/#review1453
-----------------------------------------------------------

Ship it!


Looks good.

- Boudewijn


On 2009-07-03 00:09:29, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/929/
> -----------------------------------------------------------
> 
> (Updated 2009-07-03 00:09:29)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> I've completely forgotten to fix this bug together with PerChannel filter. Here is a patch for this.
> It changes the format of saved preset, but this story is the same as for PerChannelFilter. Presets has been broken for a very long time, so i'm not sure someone still have a working .kra file with saved adjustment layer. =) Btw, curves has already changed themselves, so this file won't work.
> New format is absolutely the same as in KisPerCahhelFilter.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/krita/plugins/filters/colorsfilters/kis_brightness_contrast_filter.h 982639 
>   /trunk/koffice/krita/plugins/filters/colorsfilters/kis_brightness_contrast_filter.cc 982639 
>   /trunk/koffice/krita/plugins/filters/colorsfilters/colorsfilters.cc 989840 
>   /trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.h 982639 
>   /trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.cc 982639 
> 
> Diff: http://reviewboard.kde.org/r/929/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel