[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice/libs/flake [POSSIBLY UNSAFE]
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2009-06-17 16:09:04
Message-ID: 200906171809.05000.t.zachmann () zagge ! de
[Download RAW message or body]

On Wed June 17 2009, you wrote:
> On Wed, 17 Jun 2009, Thorsten Zachmann wrote:
> > Hello,
> >
> > > Note: I moved KoRTree from KoMain to flake, since it was used by
> > > flake and kspread, and kspread uses flake anyway.
> >
> > maybe KoRTree can be moved to a place where it is easier for other apps
> > (outside of koffice) to use. As far as I remember it should not have any
> > dependencies into other parts of koffice.
>
> I considered putting it in a lib all of its own :-). Then I considered
> KoBase, but that is depenedent on KoStore. I'm not sure what the right
> solution is, but I'm open to any hints.

how about removing the only dependency on KoStore which is 

void KoUnit::saveOdf(KoXmlWriter* settingsWriter, KoUnit _unit)
{
    settingsWriter->addConfigItem("unit", unitName(_unit));
}

if I'm not mistaken. We could move this function to a helper function into 
koodf. If we can remove this dependency KoBase is no longer dependent on 
kostore and it is easy to move stuff like KoRTree into it.

Thorsten

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]