[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add "extract" option to already present
From:       Thomas Zander <zander () kde ! org>
Date:       2009-06-14 17:04:16
Message-ID: 200906141904.16931.zander () kde ! org
[Download RAW message or body]

As I understand the main usecase is that it saves you from typing unzip on 
the shell and having to know when the converter is done writing to the temp 
file.
Can we please look into fixing that then?  Renaming the temp file to something 
ending like .odf for example.

I don't think your added functioanlity is a good idea; its unmaintainable 
code since its only triggered in very specific usecases (when compiling in 
debug mode and when passing an env variable of a specific value).

Also I think that using koconverter is a better way to do testing of filters. 
It is not unlikely there is a bug in kwords loading so checking the odt 
written by the filter is a much better way to check for correctness of the 
filter.


On Sunday 14. June 2009 17.15.48 Jaroslaw Staniek wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/832/
> -----------------------------------------------------------
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This patch adds "extract" option to already present KOFFICE_DEBUG_FILTERS
> env. variable.
>
> KOffice filters create temporary ODF files during importing. These files
> are removed as soon as the resulting file is opened.
>
> If you need to examine the temporary file, set KOFFICE_DEBUG_FILTERS
> environment variable to "extract" value in order to get the file kept and
> its contents extracted.
>
> To just keep the .tmp file without extracting it, set
> KOFFICE_DEBUG_FILTERS to anything but "extract", e.g.: %
> KOFFICE_DEBUG_FILTERS=1 kword file.doc
>
> More info: http://wiki.koffice.org/index.php?title=File_filters#Debugging
>
>
> Diffs
> -----
>
>   /trunk/koffice/libs/main/KoDocument.cpp 980442
>
> Diff: http://reviewboard.kde.org/r/832/diff
>
>
> Testing
> -------
>
> Tested on KWord trunk, import from external formats to ODF.
>

-- 
Thomas Zander

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]