[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review needed for kchart patch
From:       Inge Wallin <inge () lysator ! liu ! se>
Date:       2009-06-06 20:28:25
Message-ID: 200906062228.25329.inge () lysator ! liu ! se
[Download RAW message or body]

On Monday 01 June 2009 06:51:28 Thorsten Zachmann wrote:
> Hello,
>
> a user reported a crash in KPresenter when a layout with a chart was used
> and the chart added. See:
>
> https://bugs.kde.org/show_bug.cgi?id=194473
>
> In a debug branch you get the following assert seen in the bt at the end of
> the mail. The problem is that the shape is not yet set but already used by
> the option widget. The attached patch fixes the crash. Is this the right
> way to fix the bug. My tests showed that all is working fine.
>
> Thorsten

Hi Thorsten,

Sorry for missing this for a while.

If the patch works, I think you can commit.  What I wonder, though, is how the 
option widget will later find out which shape it is dealing with.

	-Inge

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]