'Re: Release: critical bug in kplato, advice needed'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Release: critical bug in kplato, advice needed
From:       Dag Andersen <danders () get2net ! dk>
Date:       2009-05-22 9:52:26
Message-ID: 200905221152.27084.danders () get2net ! dk
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Fredag 22 maj 2009 11:47:23 skrev Boudewijn Rempt:
> On Friday 22 May 2009, Dmitry Kazakov wrote:
> > "Q_ASSERT() is useful for testing pre- and post-conditions during
> > development. It does nothing if QT_NO_DEBUG was defined during
> > compilation."
> >
> > I think kplato is build in Release mode and QT_NO_DEBUG was defined. So
> > Q_ASSERT is nothing there. =)
Ahh, stupid code, then.
>
> Yes -- in fact the Qt docs do warn against relying on side effects in
> assert statements. I've been bitten by that, too, before.
Thanks.
So, how do we handle this for the release? New tag or instructions for 
packagers?
-- 
Mvh.
Dag Andersen

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;">Fredag 22 maj 2009 11:47:23 skrev Boudewijn \
Rempt:<br> &gt; On Friday 22 May 2009, Dmitry Kazakov wrote:<br>
&gt; &gt; "Q_ASSERT() is useful for testing pre- and post-conditions during<br>
&gt; &gt; development. It does nothing if QT_NO_DEBUG was defined during<br>
&gt; &gt; compilation."<br>
&gt; &gt;<br>
&gt; &gt; I think kplato is build in Release mode and QT_NO_DEBUG was defined. So<br>
&gt; &gt; Q_ASSERT is nothing there. =)<br>
Ahh, stupid code, then.<br>
&gt;<br>
&gt; Yes -- in fact the Qt docs do warn against relying on side effects in<br>
&gt; assert statements. I've been bitten by that, too, before.<br>
Thanks.<br>
So, how do we handle this for the release? New tag or instructions for packagers?<br>
-- <br>
Mvh.<br>
Dag Andersen</p></body></html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 