[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Release: critical bug in kplato, advice needed
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2009-05-22 9:34:50
Message-ID: ae32c1ef0905220234i454bbdeeq279af70051f18298 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


"Q_ASSERT() is useful for testing pre- and post-conditions during
development. It does nothing if QT_NO_DEBUG was defined during compilation."

I think kplato is build in Release mode and QT_NO_DEBUG was defined. So
Q_ASSERT is nothing there. =)



On Fri, May 22, 2009 at 1:28 PM, Dag Andersen <danders@get2net.dk> wrote:

> Hi,
> I got a report a few days ago that rc1 release of kplato acted strange, it
> does not schedule projects correctly. The reporter used kubuntu/jaunty so
> I've installed that to check it out.
>
>
> I suspect that this will be a problem also for the just tagged release also
> so how do we handle that?
>
>
> I've tracked it down to the following code in kptschedule.cpp line 840:
> Q_ASSERT ( add( a ) == true );
> Q_ASSERT ( node->add( a ) == true );
>
>
> AFAICS the add() method is never called.
>
>
> Changing the code to:
> bool result = add( a );
> Q_ASSERT ( result == true );
> result = node->add( a );
> Q_ASSERT ( result == true );
>
>
> seems to work
>
>
> I don't know what causes this, maybe compile options/optimaization?
> Any advice?
> --
> Mvh.
> Dag Andersen
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
>
>


-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

&quot;<meta http-equiv="Content-Type" content="text/html; charset=utf-8"><span \
class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); \
font-family: Arial; font-size: 14px; font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; \
text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: \
0px;">Q_ASSERT() is useful for testing pre- and post-conditions during development. \
It does nothing if<span class="Apple-converted-space">  \
</span><tt>QT_NO_DEBUG</tt><span class="Apple-converted-space">  </span>was defined \
during compilation.&quot;<br> <br>I think kplato is build in Release mode and \
QT_NO_DEBUG was defined. So Q_ASSERT is nothing there. =)<br></span><br><br><br><div \
class="gmail_quote">On Fri, May 22, 2009 at 1:28 PM, Dag Andersen <span \
dir="ltr">&lt;<a href="mailto:danders@get2net.dk">danders@get2net.dk</a>&gt;</span> \
wrote:<br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, \
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div style="font-family: \
&#39;DejaVu Sans&#39;; font-size: 9pt; font-weight: 400; font-style: normal;"> \
Hi,<br> I got a report a few days ago that rc1 release of kplato acted strange, it \
does not schedule projects correctly. The reporter used kubuntu/jaunty so I&#39;ve \
installed that to check it out.<br> <p style="margin: 0px; text-indent: \
0px;"><br></p>I suspect that this will be a problem also for the just tagged release \
also so how do we handle that?<br> <p style="margin: 0px; text-indent: \
0px;"><br></p>I&#39;ve tracked it down to the following code in kptschedule.cpp line \
840:<br>  Q_ASSERT ( add( a ) == true );<br>
    Q_ASSERT ( node-&gt;add( a ) == true );<br>
<p style="margin: 0px; text-indent: 0px;"><br></p>AFAICS the add() method is never \
called.<br> <p style="margin: 0px; text-indent: 0px;"><br></p>Changing the code \
to:<br>  bool result = add( a );<br>
    Q_ASSERT ( result == true );<br>
    result = node-&gt;add( a );<br>
    Q_ASSERT ( result == true );<br>
<p style="margin: 0px; text-indent: 0px;"><br></p>seems to work<br>
<p style="margin: 0px; text-indent: 0px;"><br></p>I don&#39;t know what causes this, \
maybe compile options/optimaization?<br> Any advice?<br>
-- <br>
Mvh.<br><font color="#888888">
Dag Andersen</font></div><br>_______________________________________________<br>
koffice-devel mailing list<br>
<a href="mailto:koffice-devel@kde.org">koffice-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/koffice-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br> \
<br></blockquote></div><br><br clear="all"><br>-- <br>Dmitry Kazakov<br>



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]