[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Krita: Size canvas feature
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-05-19 18:49:41
Message-ID: 20090519184941.12633.80398 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/220/#review1156
-----------------------------------------------------------

Ship it!


Looks good! Let's start here, and then add % boxes, too. Please commit! (Or get an \
svn account).

- Boudewijn


On 2009-05-19 11:15:18, antiquark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/220/
> -----------------------------------------------------------
> 
> (Updated 2009-05-19 11:15:18)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to change the size of the canvas in Krita and set the \
> anchoring point. The patch makes use of KisCropVisitor to perform cropping. 
> The plugin adds some PNG images which are available here -> \
> http://www.2shared.com/file/4988334/236a0051/arrowstar.html.  They should be \
> extracted in /krita/plugins/viewplugins/imagesize/pics 
> 
> Diffs
> -----
> 
> /trunk/koffice/plugins/extensions/imagesize/imagesize.rc 970150 
> /trunk/koffice/plugins/extensions/imagesize/kcanvaspreview.h PRE-CREATION 
> /trunk/koffice/plugins/extensions/imagesize/imagesize.cc 970150 
> /trunk/koffice/plugins/extensions/imagesize/imagesize.h 970150 
> /trunk/koffice/plugins/extensions/imagesize/dlg_canvassize.cc PRE-CREATION 
> /trunk/koffice/plugins/extensions/imagesize/CMakeLists.txt 970150 
> /trunk/koffice/plugins/extensions/imagesize/dlg_canvassize.h PRE-CREATION 
> /trunk/koffice/image/kis_image.h 970150 
> /trunk/koffice/image/kis_image.cc 970150 
> /trunk/koffice/plugins/extensions/imagesize/kcanvaspreview.cc PRE-CREATION 
> /trunk/koffice/plugins/extensions/imagesize/pics/arrow_east.png UNKNOWN 
> /trunk/koffice/plugins/extensions/imagesize/pics/arrow_north.png UNKNOWN 
> /trunk/koffice/plugins/extensions/imagesize/pics/arrow_north_east.png UNKNOWN 
> /trunk/koffice/plugins/extensions/imagesize/pics/arrow_north_west.png UNKNOWN 
> /trunk/koffice/plugins/extensions/imagesize/pics/arrow_south.png UNKNOWN 
> /trunk/koffice/plugins/extensions/imagesize/pics/arrow_south_east.png UNKNOWN 
> /trunk/koffice/plugins/extensions/imagesize/pics/arrow_south_west.png UNKNOWN 
> /trunk/koffice/plugins/extensions/imagesize/pics/arrow_west.png UNKNOWN 
> /trunk/koffice/plugins/extensions/imagesize/wdg_canvassize.ui PRE-CREATION 
> /trunk/koffice/ui/kis_image_manager.h 970150 
> /trunk/koffice/ui/kis_image_manager.cc 970150 
> 
> Diff: http://reviewboard.kde.org/r/220/diff
> 
> 
> Testing
> -------
> 
> Works fine, except when there are masks. The KisCropVisitor class does not handle \
> cropping of masks and therefore this deficiency is propagated. 
> 
> Screenshots
> -----------
> 
> Size Canvas
> http://reviewboard.kde.org/r/220/s/44/
> Updated canvas size
> http://reviewboard.kde.org/r/220/s/123/
> 
> 
> Thanks,
> 
> antiquark
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]