[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Lock shape shouldn't be selectable
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2009-04-18 12:58:08
Message-ID: 20090418125808.26778.34372 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/606/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

One thing that annoys me in karbon is that locked shapes are still selectable. If \
it's locked, there is no point in selecting it (except to cooy it ? (but one might \
note that most docker don't care if a shape is editable or not, but then that would \
be a bug) ). I am not sure what's the correct solution (probably not my patch, but \
for now it solves my annoyance :) and to start the debate ), would the correct fix \
be: 1) to make lock/unlock in karbon's layer box call setSelectable ?
2) add an icon to that layerbox to prevent selection ?

The second option gives more power... and more clutter...


Diffs
-----

  trunk/koffice/libs/flake/KoShape.cpp 955671 

Diff: http://reviewboard.kde.org/r/606/diff


Testing
-------


Thanks,

Cyrille

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]