[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Filter effects for karbon
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2009-04-13 11:34:05
Message-ID: 20090413113405.23712.3809 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/580/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

New version of the patch (couldn't update the previous one, so opening a new \
request). This time, the rendering is done in flake, KoShapeManager.

For now, there is still the karbon plugin to create the filter, obviously it will be \
replaced by a tool... The real interesting part is the patch to lib/flake.

I have two issues:
* one the rect created to do the filtering is too big when the shape is rotated, I \
was also unable to use the painter.clip to reduce the rect, not sure why, but if I \
                tried to use it, then only part of the shape became visible
* there seem to be a bug in Qt, when you have an image with a transparent bottom, \
then when it is rotated, there is a thin line appearing at the bottom of the image, \
one can easily reproduce it with the picture shape

If it's ok, I would like to commit the flake part, and then work on a tool.


Diffs
-----

  trunk/koffice/karbon/plugins/CMakeLists.txt 951712 
  trunk/koffice/karbon/plugins/effectsfilters/CMakeLists.txt PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/FilterEffects.h PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/FilterEffects.cpp PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/KoInvertFilterEffect.h PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/KoInvertFilterEffect.cpp PRE-CREATION 
  trunk/koffice/karbon/plugins/effectsfilters/karbonfiltereffects.rc PRE-CREATION 
  trunk/koffice/libs/flake/CMakeLists.txt 951712 
  trunk/koffice/libs/flake/KoFilterEffect.h PRE-CREATION 
  trunk/koffice/libs/flake/KoFilterEffect.cpp PRE-CREATION 
  trunk/koffice/libs/flake/KoShape.h 951712 
  trunk/koffice/libs/flake/KoShape.cpp 951712 
  trunk/koffice/libs/flake/KoShapeManager.cpp 951712 

Diff: http://reviewboard.kde.org/r/580/diff


Testing
-------


Thanks,

Cyrille

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]