[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Solves unnumbered heading gets a bullet after
From:       "Thomas Zander" <zander () kde ! org>
Date:       2009-03-30 13:52:56
Message-ID: 20090330135256.6521.6842 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/459/#review725
-----------------------------------------------------------

Ship it!


Looks good to me.

- Thomas


On 2009-03-28 11:46:53, Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/459/
> -----------------------------------------------------------
> 
> (Updated 2009-03-28 11:46:53)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch solves a problem highlighted by the example file of Bug 130825. An unnumbered \
> heading was drawned with a small square (like a list square bullet) after loading. This \
> square would disappear after reapplying the heading style. On a side note, Bug 130825 can now \
> be closed, as the bug it related to was solved some time ago. 
> 
> This addresses bug 130825.
> https://bugs.kde.org/show_bug.cgi?id=130825
> 
> 
> Diffs
> -----
> 
> trunk/koffice/plugins/textshape/Layout.cpp 946068 
> trunk/koffice/plugins/textshape/ListItemsHelper.cpp 946068 
> 
> Diff: http://reviewboard.kde.org/r/459/diff
> 
> 
> Testing
> -------
> 
> The test file of bug 130825 loads fine. TestDocumentLayout also passes.
> 
> 
> Thanks,
> 
> Pierre
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]