[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Krita: Turn on and off queueing of painting tasks
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2009-03-23 16:54:33
Message-ID: 20090323165433.17706.28171 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/361/#review570
-----------------------------------------------------------


I don't understand the point of not queuing. The main idea for queuing is to not lose \
paint events because some paint op use a lot of CPU power, so the queuing is done to \
have main thread providing events, while a secondary thread do the painting, that way \
we never lose input events (or shall I say, we are less likely to lose paint event). \
So somehow, by disabling/enabling the queuing you make a paint effect that depends on \
the CPU load, which I think isn't a good idea, as it will be difficult to control by \
the user.

- Cyrille


On 2009-03-19 13:36:44, Lukáš Tvrdý wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/361/
> -----------------------------------------------------------
> 
> (Updated 2009-03-19 13:36:44)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds new check box to Tool option of the freehand tool. It's aim is to \
> provide different visual feedback mainly for big brushes.  E.g. for sumi with \
> radius around 30, deform brush with radius 150. 
> It is probably not for 2.0, because it contains new string. 
> 
> When the checkbox is turned on (by default), the painting tasks are queued.
> When it is not checked, it paints straight as it goes. It gives little different \
> behaviour to paintops, the results are different. 
> 
> Diffs
> -----
> 
> koffice/krita/plugins/tools/defaulttools/kis_tool_brush.h 941383 
> koffice/krita/plugins/tools/defaulttools/kis_tool_brush.cc 941383 
> koffice/krita/ui/tool/kis_tool_freehand.h 941383 
> koffice/krita/ui/tool/kis_tool_freehand.cc 941383 
> 
> Diff: http://reviewboard.kde.org/r/361/diff
> 
> 
> Testing
> -------
> 
> I did some testing and it gives nice results.
> 
> 
> Thanks,
> 
> Lukáš
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]