[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Hard coded default text style (font family,
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2009-03-23 16:20:22
Message-ID: 20090323162022.17094.98405 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/312/#review569
-----------------------------------------------------------

Ship it!


Patch looks fine

- Thorsten


On 2009-03-15 04:38:58, Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/312/
> -----------------------------------------------------------
> 
> (Updated 2009-03-15 04:38:58)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds hard coded values for text style. These are used if the odf file does not set \
> these in any way and if defaultstyles.xml is not provided. It also adds a test for \
> nestedSpans 
> 
> Diffs
> -----
> 
> trunk/koffice/plugins/textshape/tests/TestLists.cpp 939486 
> trunk/koffice/libs/odf/KoOdfLoadingContext.cpp 939486 
> trunk/koffice/libs/kotext/opendocument/tests/TestLoading.cpp 939486 
> trunk/koffice/libs/kotext/styles/KoCharacterStyle.h 939486 
> trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 939486 
> 
> Diff: http://reviewboard.kde.org/r/312/diff
> 
> 
> Testing
> -------
> 
> libs/kotext/opendocument/tests/TestLoading and plugins/textshape/tests/TestDocumentLayout \
> both succeed. also tested an odp Thorsten provided, which works. 
> 
> Thanks,
> 
> Pierre
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]