[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix embedding KWord
From:       "Jan Hambrecht" <jaham () gmx ! net>
Date:       2009-03-22 20:30:53
Message-ID: 20090322203053.20864.53805 () localhost
[Download RAW message or body]



> On 2009-03-07 13:59:40, Thomas Zander wrote:
> > trunk/koffice/kword/part/KWDocument.cpp, line 213
> > <http://reviewboard.kde.org/r/176/diff/1/?file=1245#file1245line213>
> > 
> > I don't see why this is needed.

I needed this to fix a crash, but maybe it is not requiered anymore. Does \
it work without?


> On 2009-03-07 13:59:40, Thomas Zander wrote:
> > trunk/koffice/kword/part/KWDocument.cpp, line 225
> > <http://reviewboard.kde.org/r/176/diff/1/?file=1245#file1245line225>
> > 
> > I don't see why this is needed.

I needed this to fix a crash, but maybe it is not requiered anymore. Does \
it work without?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/176/#review398
-----------------------------------------------------------


On 2009-02-24 15:26:39, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/176/
> -----------------------------------------------------------
> 
> (Updated 2009-02-24 15:26:39)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> The patch fixes embedding KWord in Konqueror. It adds some test for a \
> valid status bar and main window. 
> 
> This addresses bug 181369.
> https://bugs.kde.org/show_bug.cgi?id=181369
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWDocument.cpp 931054 
> trunk/koffice/kword/part/KWView.cpp 931054 
> 
> Diff: http://reviewboard.kde.org/r/176/diff
> 
> 
> Testing
> -------
> 
> Tested with embedding in Konqueror for viewing local odt files.
> 
> 
> Thanks,
> 
> Jan
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]