[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix loading with shape dependencies
From:       "Jan Hambrecht" <jaham () gmx ! net>
Date:       2009-03-22 20:28:40
Message-ID: 20090322202840.20715.594 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/299/#review555
-----------------------------------------------------------

Ship it!


Overall i think the patch is ok.


trunk/koffice/libs/flake/KoConnectionShapeLoadingUpdater.h
<http://reviewboard.kde.org/r/299/#comment335>

    maybe change the index to an enum ?


- Jan


On 2009-03-14 00:04:11, Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/299/
> -----------------------------------------------------------
> 
> (Updated 2009-03-14 00:04:11)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch fixs https://bugs.kde.org/show_bug.cgi?id=186284. I just like to get \
> some review before I commit as we are short before the relase.
> 
> The problem is there for shapes that depend on other shapes to be there when \
> loaded. This is not allways the case as the shape one shape depends on might get \
> loaded after that shape, and so it is not found during loading. 
> E.g. :
> 
> Shape A is an artistic text shape and depends on shape P
> Shape P is loaded after shape A
> 
> so while loading shape A shape P is not yet there and it can't attach itself to the \
> path. 
> The patch adds a posibility to do parts of the loading at a later point when the \
> shape on which you depend is fully loaded. 
> Here you can download a test file to use for testing.
> 
> http://www.zagge.de/files/connection.odg
> 
> I will be without computer access from 15.3.-22.3. so be patient. Documenting code \
> will follow. 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=186284.
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=186284
> 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/karbon/CMakeLists.txt 938206 
> trunk/koffice/libs/flake/CMakeLists.txt 938206 
> trunk/koffice/libs/flake/KoConnectionShape.cpp 938206 
> trunk/koffice/libs/flake/KoConnectionShapeLoadingUpdater.h PRE-CREATION 
> trunk/koffice/libs/flake/KoConnectionShapeLoadingUpdater.cpp PRE-CREATION 
> trunk/koffice/libs/flake/KoLoadingShapeUpdater.h PRE-CREATION 
> trunk/koffice/libs/flake/KoLoadingShapeUpdater.cpp PRE-CREATION 
> trunk/koffice/libs/flake/KoShapeLoadingContext.h 938206 
> trunk/koffice/libs/flake/KoShapeLoadingContext.cpp 938206 
> trunk/koffice/libs/flake/KoShapeRegistry.cpp 938206 
> trunk/koffice/plugins/artistictextshape/ArtisticTextShape.cpp 938206 
> trunk/koffice/plugins/artistictextshape/ArtisticTextShapeLoadingUpdater.h \
> PRE-CREATION  trunk/koffice/plugins/artistictextshape/ArtisticTextShapeLoadingUpdater.cpp \
> PRE-CREATION  trunk/koffice/plugins/artistictextshape/CMakeLists.txt 938206 
> 
> Diff: http://reviewboard.kde.org/r/299/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thorsten
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]