[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: 4th try. Fixed bug in KisPerChannelFilter that
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-03-12 10:38:37
Message-ID: 20090312103837.16597.3889 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/203/#review462
-----------------------------------------------------------

Ship it!


I'd say, let's go with this for now.

- Boudewijn


On 2009-03-10 14:19:10, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/203/
> -----------------------------------------------------------
> 
> (Updated 2009-03-10 14:19:10)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Now bookmarks are loaded/saved well. It was because of deprecated (i guess) \
> interfaces used in KisPerChannelFilter, those are swept out of \
> KisPropertiesConfiguration and KisSerializableConfiguration long ago =) 
> And a bit of refactoring =)
> 
> Could someone review and/or test it before the commit?
> 
> 
> Diffs
> -----
> 
> trunk/koffice/krita/image/filter/kis_filter_configuration.h 935753 
> trunk/koffice/krita/image/filter/kis_filter_configuration.cc 935753 
> trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.h 935753 
> trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.cc 935753 
> 
> Diff: http://reviewboard.kde.org/r/203/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]