[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix embedding KWord
From:       "Thomas Zander" <zander () kde ! org>
Date:       2009-03-07 21:59:36
Message-ID: 20090307215936.18345.94718 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/176/#review398
-----------------------------------------------------------

Ship it!


The statusbar patch looks good, the checks for view seems to be fixed elsewhere already.
Can you commit the parts from KWView?


trunk/koffice/kword/part/KWDocument.cpp
<http://reviewboard.kde.org/r/176/#comment233>

    I don't see why this is needed.



trunk/koffice/kword/part/KWDocument.cpp
<http://reviewboard.kde.org/r/176/#comment234>

    I don't see why this is needed.


- Thomas


On 2009-02-24 15:26:39, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/176/
> -----------------------------------------------------------
> 
> (Updated 2009-02-24 15:26:39)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> The patch fixes embedding KWord in Konqueror. It adds some test for a valid status bar and main window.
> 
> 
> This addresses bug 181369.
>     https://bugs.kde.org/show_bug.cgi?id=181369
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/kword/part/KWDocument.cpp 931054 
>   trunk/koffice/kword/part/KWView.cpp 931054 
> 
> Diff: http://reviewboard.kde.org/r/176/diff
> 
> 
> Testing
> -------
> 
> Tested with embedding in Konqueror for viewing local odt files.
> 
> 
> Thanks,
> 
> Jan
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]