[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Krita: Size canvas feature
From:       "Sven Langkamp" <sven.langkamp () gmail ! com>
Date:       2009-03-03 1:16:05
Message-ID: 20090303011605.691.81887 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/220/#review337
-----------------------------------------------------------


Works fine, though I noticed some things:

-The action is name "Size Canvas", while the old one was "Resize Image". Either the \
                new action or the "Resize image to size current layer" action needs \
                to be renamed.
-I think showing the current image size isn't needed, as the intial values already \
                show the current size and it's visible in the statusbar too.
-It would be nice if the size spinbox has an option to keep the aspect ratio (chain \
                symbol)
-it should be possible to optionally not crop the layers
-it's not completely obvious what the arrow buttons do (a preview would be nice)

The patch is ok for me. Unfortunately we can't apply it in the current freeze.

- Sven


On 2009-03-02 10:48:28, antiquark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/220/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 10:48:28)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch adds the ability to change the size of the canvas in Krita and set the \
> anchoring point. The patch makes use of KisCropVisitor to perform cropping. 
> The plugin adds some PNG images which are available here -> \
> http://www.2shared.com/file/4988334/236a0051/arrowstar.html.  They should be \
> extracted in /krita/plugins/viewplugins/imagesize/pics 
> 
> Diffs
> -----
> 
> /trunk/koffice/krita/image/kis_image.h 934295 
> /trunk/koffice/krita/image/kis_image.cc 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/CMakeLists.txt 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/dlg_canvassize.h PRE-CREATION 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/dlg_canvassize.cc PRE-CREATION 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/imagesize.h 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/imagesize.cc 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/imagesize.rc 934295 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/CMakeLists.txt PRE-CREATION \
>                 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_east.png UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_north.png UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_north_east.png \
>                 UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_north_west.png \
>                 UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_south.png UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_south_east.png \
>                 UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_south_west.png \
>                 UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/pics/arrow_west.png UNKNOWN 
> /trunk/koffice/krita/plugins/viewplugins/imagesize/wdg_canvassize.ui PRE-CREATION 
> /trunk/koffice/krita/ui/kis_image_manager.h 934295 
> /trunk/koffice/krita/ui/kis_image_manager.cc 934295 
> 
> Diff: http://reviewboard.kde.org/r/220/diff
> 
> 
> Testing
> -------
> 
> Works fine, except when there are masks. The KisCropVisitor class does not handle \
> cropping of masks and therefore this deficiency is propagated. 
> 
> Screenshots
> -----------
> 
> Size Canvas
> http://reviewboard.kde.org/r/220/s/44/
> 
> 
> Thanks,
> 
> antiquark
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic