--===============1345896922==
Content-Type: multipart/signed;
  boundary="nextPart12145840.LtQiKSiRAm";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart12145840.LtQiKSiRAm
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Saturday 21. February 2009 07:58:26 Thorsten Zachmann wrote:
> > Well, his answer was "I am not sure. Better ask Thorsten".
>
> stange. Maybe a misunderstanding. The styles and the style manager
> where done by Thomas. What I'm not sure off is if
> =C2=A0
> qobject_cast<KoStyleManager>(paragStyle->parent());
>
> works. Thomas should be able to answer I hope.
>
> I think we should pass the KoShapeSavingContext to the saveOdf function of
> the styles and the styleManager. Only if we do it like that we have access
> to the data we need e.g.KoSharedSavingData when saving the stlye.
> The KoSharedSavingData would be added to the KoShapeSavingContext from the
> KoStyleManager::saveOdf() so it could be used later.

My point of view is that code that works on more than one style (for exampl=
e=20
the nextStyle property) should not live in the style save method.
So I'd expect the styleManager or a similar class to figure how how to stor=
e=20
all the (named) styles, in what order and then to help with things like=20
saving the 'nextStyle' property.  For example by saving it directly to the=
=20
xml or if thats not possible by setting the data required on the context so=
=20
the style can find it.

In both cases the style finding the container its in (style manager) is=20
unneeded. Which is good as it truly feels like a hack :)
This is the reason I pointed at you, Thorsten, since I don't know enough ab=
out=20
style saving to know how to do this properly, following something like the=
=20
strategy I wrote above.
=2D-=20
Thomas Zander

--nextPart12145840.LtQiKSiRAm
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEABECAAYFAkmn4/YACgkQCojCW6H2z/RAoACfTpGSr63OjbcyNe6xc9a3UHkD
cSIAoOvqEdcZh+hEDSSRJBMPL4CRmn5r
=yASZ
-----END PGP SIGNATURE-----

--nextPart12145840.LtQiKSiRAm--

--===============1345896922==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============1345896922==--