[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Improvements and Bug fixes for Levels Filter
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2009-02-27 10:05:50
Message-ID: 20090227100550.14526.87498 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/182/#review290
-----------------------------------------------------------

Ship it!


Looks good!

- Boudewijn


On 2009-02-25 10:18:58, antiquark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/182/
> -----------------------------------------------------------
> 
> (Updated 2009-02-25 10:18:58)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> wdg_level.ui
> ------------
> 
> - removed unnecessary layouts in layouts
> - added spinbox for gamma
> - moved logarithmic checkbox location
> 
> kgradientslider
> ---------------
> 
> - works in arbitrary size, not just 256
> - improved picking logic
> - improved graphics
> - refactoring according to HACKING file specifications
> 
> kis_level_filter
> ----------------
> 
> - histogram works correctly (no log(0) error)
> - resizable histogram with nearest neighbour interpolation
> - input validation for spinboxes by changin max & min values
> - refactoring according to HACKING file specifications
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/krita/plugins/filters/levelfilter/kgradientslider.h 931681 
>   /trunk/koffice/krita/plugins/filters/levelfilter/kgradientslider.cc 931681 
>   /trunk/koffice/krita/plugins/filters/levelfilter/kis_level_filter.h 931681 
>   /trunk/koffice/krita/plugins/filters/levelfilter/kis_level_filter.cc 931681 
>   /trunk/koffice/krita/plugins/filters/levelfilter/wdg_level.ui 931681 
> 
> Diff: http://reviewboard.kde.org/r/182/diff
> 
> 
> Testing
> -------
> 
> Tried different things and seemed to work fine.
> 
> 
> Screenshots
> -----------
> 
> Levels Filter after Patch
>   http://reviewboard.kde.org/r/182/s/32/
> 
> 
> Thanks,
> 
> antiquark
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]