[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix embedding kpresenter in konqueror
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2009-02-25 4:09:10
Message-ID: 20090225040910.6677.41961 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/175/#review259
-----------------------------------------------------------

Ship it!


Looks good. There is only one style issue I like to get fixed before you commit. Can \
you please always use {} even if there is only one line in the if e.g. 

if (shell) {
    m_documentStructureDocker->setMasterMode(master);
}

Thanks for looking into this.

- Thorsten


On 2009-02-24 14:01:17, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/175/
> -----------------------------------------------------------
> 
> (Updated 2009-02-24 14:01:17)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> As the summary says, this patch fixes embedding kpresenter into konqueror. It \
> changes KoPaView and KPrView to not create or access dockers when no main window is \
> available, e.g. when embedding. 
> 
> This addresses bugs 181369 and 185429.
> https://bugs.kde.org/show_bug.cgi?id=181369
> https://bugs.kde.org/show_bug.cgi?id=185429
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kpresenter/part/KPrView.cpp 931054 
> trunk/koffice/libs/kopageapp/KoPAView.cpp 931054 
> 
> Diff: http://reviewboard.kde.org/r/175/diff
> 
> 
> Testing
> -------
> 
> I checked local files to open embeded in konqi as well the file linked to in bug \
> #185429 and they work now. 
> 
> Thanks,
> 
> Jan
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]