From koffice-devel  Tue Feb 24 07:33:52 2009
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: Tue, 24 Feb 2009 07:33:52 +0000
To: koffice-devel
Subject: Re: Review Request: Workaround to for selection changed events
Message-Id: <20090224073352.16508.51227 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=123546079609315


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/170/#review256
-----------------------------------------------------------

Ship it!


Yeah... Well, it beats refactoring the whole kaboodle before 2.0!

- Boudewijn


On 2009-02-23 13:12:34, Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/170/
> -----------------------------------------------------------
> 
> (Updated 2009-02-23 13:12:34)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This is a workaround for the missing selectionChanged signals in Krita (see bug 165869 and 184993). It updates the global selection with all selected shapes every time a shape layer selection get changed. It's rather ugly, but for 2.0 I don't see a way around it.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/krita/ui/flake/kis_shape_controller.h 930450 
>   trunk/koffice/krita/ui/flake/kis_shape_controller.cpp 930450 
> 
> Diff: http://reviewboard.kde.org/r/170/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel