[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix crash on double clicking a file in the open
From:       "Jan Hambrecht" <jaham () gmx ! net>
Date:       2009-02-23 21:43:56
Message-ID: 20090223214356.7059.92480 () localhost
[Download RAW message or body]



> On 2009-02-23 01:39:16, Boudewijn Rempt wrote:
> > Look good to me, though I'd just delete the timer, instead of commenting it out.

Right i simply forgot that.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/154/#review243
-----------------------------------------------------------


On 2009-02-22 10:15:20, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/154/
> -----------------------------------------------------------
> 
> (Updated 2009-02-22 10:15:20)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch fixes a crash when double clicking on a file in the open existing \
> document pane of the startup widget. If the loading of the document took longer \
> than 1 second the application crashed. This was due to the startup widget being \
> deleted on the first click but before the double cleck event got handled. The patch \
> removes the use of a single shot timer with a one second elapse time and uses a \
> deleteLater call on the startupWidget instead. Please review as i am not sure if \
> the deleteLater call is the right thing to do here. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/main/KoDocument.h 929963 
> trunk/koffice/libs/main/KoDocument.cpp 929963 
> 
> Diff: http://reviewboard.kde.org/r/154/diff
> 
> 
> Testing
> -------
> 
> I could reproduce the crash with karbon and kpresenter before, the patch fixes both \
> of them. 
> 
> Thanks,
> 
> Jan
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]