[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: The patch for KCurve and KisPerChannelFilter
From:       "Dmitry Kazakov" <dimula73 () gmail ! com>
Date:       2009-02-22 20:34:16
Message-ID: 20090222203416.6232.88088 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/128/
-----------------------------------------------------------

(Updated 2009-02-22 12:34:16.436559)


Review request for KOffice.


Changes
-------

Fixed misprint in KCurve::Private::setCurveModified where emitting signal was \
commented out.


Summary
-------

This patch goes together with the next one!
http://reviewboard.kde.org/r/129/

What is done:
KCurve:
- implemented cubic splines in KCurve widget. Now all the calculations are made \
                inside KCubicSpline template.
- faster calculations of the spline because of caching of the coefficients inside the \
                template
- faster (*much faster*) redrawing of the curve because of caching of the _scaled_ \
                @m_pix histogram image in @m_pixmapCache object
- fixed 'out_of_range' bug when you tried to delete the last point of the curve

KCurve+KisPerChannelWidget
- added In/Out spinboxes like in photoshop to allow user to modify the curve with \
                keyboard
- with spinboxes you can move the point to any place of the curve, so you can change \
                the order of the points
- added handy function that creates new point in the middle of the curve and focuses \
                on spinboxes to set it
- and a few small fixes


The fist patch changes KCurve class. The second one makes KisPerChannelFilter use new \
features.


PS:
What is planned to be done:
1) Look through preview mechanism, because it still slows everything down much.
2) Let user unselect the point of the curve by clicking on empty area
2,5) Hide In/Out controls when nothing selected
3) Far-far-future: color sampler mode for the curve (clicking on the canvas shows the \
point on the curve)


Diffs (updated)
-----

  trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.h 930016 
  trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.cc 930016 
  trunk/koffice/krita/plugins/filters/colorsfilters/wdg_perchannel.ui 930016 
  trunk/koffice/krita/ui/widgets/kcurve.h 930016 
  trunk/koffice/krita/ui/widgets/kcurve.cc 930016 
  trunk/koffice/krita/ui/widgets/kcurve_p.h PRE-CREATION 

Diff: http://reviewboard.kde.org/r/128/diff


Testing
-------


Thanks,

Dmitry

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]