-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/153/#review236
-----------------------------------------------------------


As the comment in the code suggests, the workaround was for Qt focussing sliders. So i think the patch is ok.

- Jan


On 2009-02-22 10:03:58, Tomas Mecir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/153/
> -----------------------------------------------------------
> 
> (Updated 2009-02-22 10:03:58)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> I need to adjust this Qt workaround to not give focus to the canvas for any situations other than those that really were initiated by scrollbars. Didn't notice any side-effects, which of course doesn't mean that there aren't any, hence this request :)
> 
> The reason for this is that I am adjusting the KSpread's cell editor to automatically adjust its height based on the size of text that it holds (only if the editor is focused, so that the user doesn't have jumping GUI when moving around cells), but this code kept throwing focus away from the cell editor, breaking things.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/flake/KoCanvasController.cpp 929371 
> 
> Diff: http://reviewboard.kde.org/r/153/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomas
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel