[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Don't refocus to canvas from non-scrollbar events
From:       "Tomas Mecir" <mecirt () gmail ! com>
Date:       2009-02-22 17:11:39
Message-ID: 20090222171139.2812.59260 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/153/
-----------------------------------------------------------

Review request for KOffice.


Summary
-------

I need to adjust this Qt workaround to not give focus to the canvas for any \
situations other than those that really were initiated by scrollbars. Didn't notice \
any side-effects, which of course doesn't mean that there aren't any, hence this \
request :)

The reason for this is that I am adjusting the KSpread's cell editor to automatically \
adjust its height based on the size of text that it holds (only if the editor is \
focused, so that the user doesn't have jumping GUI when moving around cells), but \
this code kept throwing focus away from the cell editor, breaking things.


Diffs
-----

  koffice/libs/flake/KoCanvasController.cpp 929371 

Diff: http://reviewboard.kde.org/r/153/diff


Testing
-------


Thanks,

Tomas

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]