[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: The patch for KCurve and KisPerChannelFilter
From:       "Dmitry Kazakov" <dimula73 () gmail ! com>
Date:       2009-02-20 19:57:15
Message-ID: 20090220195715.15426.33909 () localhost
[Download RAW message or body]



> On 2009-02-20 05:43:35, Boudewijn Rempt wrote:
> > When playing with the patch, I noticed that the shape of the curve very quickly \
> > gets a sort of saw-tooth like shape. But that may be just because I am used to \
> > the other curve. I notice that photoshop7 also has a kind of freehand draw mode \
> > for the curve -- but that looks a bit useless. 
> > I do think that we should have an option for anti-aliasing the curve, and that it \
> > should be on by default. Just because it looks better, even though it is less \
> > accurate. 
> > Given that there are no string changes, I think that committing this patch is \
> > safe: we have at least one beta to go (next week) and one rc.

> > When playing with the patch, I noticed that the shape of the curve very quickly \
> > gets a sort of saw-tooth like shape.
Yes. It's because of POINT_AREA constant. I guess it's too small in comparison with \
corresponding constant in photoshop. But it hurts nobody, i guess. At least user can \
make the curve as sharp as he wants.

> > freehand draw mode for the curve -- but that looks a bit useless
I agree, but there are only few problems implementing it.

> > anti-aliasing the curve
it makes the curve work much slower. This is a tool and it should work but not paint \
beautiful images, imho. I don't know configuration infrastructure yet, so i'll think \
about an option later :)


- Dmitry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/129/#review198
-----------------------------------------------------------


On 2009-02-19 13:30:58, Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/129/
> -----------------------------------------------------------
> 
> (Updated 2009-02-19 13:30:58)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This is addition to the previous request: http://reviewboard.kde.org/r/128/
> 
> 
> Diffs
> -----
> 
> trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.h 928664 
> trunk/koffice/krita/plugins/filters/colorsfilters/kis_perchannel_filter.cc 928664 
> trunk/koffice/krita/plugins/filters/colorsfilters/wdg_perchannel.ui 928664 
> 
> Diff: http://reviewboard.kde.org/r/129/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]