[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Allow setting of a custom manifest file
From:       Jan Hambrecht <jaham () gmx ! net>
Date:       2009-02-20 14:18:22
Message-ID: 499EBBAE.1050508 () gmx ! net
[Download RAW message or body]

Sven Langkamp wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/136/
> -----------------------------------------------------------
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Allows to set a custom manifest file to the KoOdfLoadingContext. Fixes loading of \
> chart shapes in Krita. 
> 
> Diffs
> -----
> 
> trunk/koffice/krita/ui/flake/kis_shape_layer.cc 928836 
> trunk/koffice/libs/odf/KoOdfLoadingContext.h 928349 
> trunk/koffice/libs/odf/KoOdfLoadingContext.cpp 928349 
> 
> Diff: http://reviewboard.kde.org/r/136/diff
> 
> 
> Testing
> -------
> 

I would rather name it setManifestFile( ... ). Other than that it looks ok.

Ciao Jan

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]