'Re: Review board'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review board
From:       Cyrille Berger <cberger () cberger ! net>
Date:       2009-02-18 9:20:27
Message-ID: 200902181020.27795.cberger () cberger ! net
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

On Wednesday 18 February 2009, Boudewijn Rempt wrote:
> Depends... I'd like to use it for patches outside my own turf, so to say,
> and perhaps for new people to submit patches. I wouldn't like having all
> commits go through reviewboard.
Oh me neither :) It's definitely not for all patches to go that way. It's 
either for patches that we are unsure about, or for external people.

> But right now I've got a patch to make saving/loading of metadata work for
> .kra, and I _would_ like some review :-)
Good use case :)

-- 
Cyrille Berger

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;">On Wednesday 18 February 2009, Boudewijn Rempt \
wrote:<br> &gt; Depends... I'd like to use it for patches outside my own turf, so to \
say,<br> &gt; and perhaps for new people to submit patches. I wouldn't like having \
all<br> &gt; commits go through reviewboard.<br>
Oh me neither :) It's definitely not for all patches to go that way. It's either for \
patches that we are unsure about, or for external people.<br> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>&gt; But right now I've got a patch to make saving/loading \
of metadata work for<br> &gt; .kra, and I _would_ like some review :-)<br>
Good use case :)<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>-- <br> Cyrille Berger</p></body></html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 