'Re: Default style'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Default style
From:       Pierre Stirnweiss <pierre.stirnweiss () t-online ! de>
Date:       2009-02-15 20:36:19
Message-ID: 200902152136.20065.pierre.stirnweiss () t-online ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Hi,

After upgrade to qt4.5, the tests stopped working with a syntax error in the 
scripts. Thanks to estan, the problem is fixed: the script had "return 
document" on the last line. In Qt 4.4, this error was not checked for (a 
return outside a function is invalid), so replacing "return document;" with 
"document;" solved the problems.
I will commit this also as separate patch.

Now, qt4.5 added two properties: fontStyleHint and fontKerning.
The test for fontKerning works, the one for fontStyleHint not.
The failure is not on the loading/saving routine but in the test script: it 
seems in QScript: romanFormat.setFontStyleHint(QFont.Serif); has no effect.

Now, looking into Qt documentation I stumbled across this:Q t does not support 
style hints on X11 since this information is not provided by the window 
system.

Could this be part of the problem? If it is not supported on our main target 
platform, should we really use it?

Pierre

>
> Thorsten
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:10pt; \
font-weight:400; font-style:normal;">Hi,<br> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>After upgrade to \
qt4.5, the tests stopped working with a syntax error in the scripts. Thanks to estan, \
the problem is fixed: the script had "return document" on the last line. In Qt 4.4, \
this error was not checked for (a return outside a function is invalid), so replacing \
"return document;" with "document;" solved the problems.<br> I will commit this also \
as separate patch.<br> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><br></p>Now, qt4.5 added two properties: \
fontStyleHint and fontKerning.<br> The test for fontKerning works, the one for \
fontStyleHint not.<br> The failure is not on the loading/saving routine but in the \
test script: it seems in QScript: romanFormat.setFontStyleHint(QFont.Serif); has no \
effect.<br> <p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>Now, looking into Qt documentation I stumbled across \
this:Q t does not support style hints on X11 since this information is not provided \
by the window system.<br> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><br></p>Could this be part of the problem? If it \
is not supported on our main target platform, should we really use it?<br> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p><p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>Pierre<br> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"><br></p>&gt;<br> &gt; \
Thorsten<br> &gt; _______________________________________________<br>
&gt; koffice-devel mailing list<br>
&gt; koffice-devel@kde.org<br>
&gt; https://mail.kde.org/mailman/listinfo/koffice-devel<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p></body></html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 