[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: File filters status...
From:       Cyrille Berger <cberger () cberger ! net>
Date:       2009-01-20 13:52:48
Message-ID: 200901201452.48590.cberger () cberger ! net
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Tuesday 20 January 2009, David Faure wrote:
> > how so ? if at the end the filter give something that can be saved ? (or
> > something that is saved), it should still work right ?
>
> What if the _input_ of a filter is a file on disk? I think you're narrowing
> your thinking to "saving from the app using in-memory structures".
Good point, but yet, KoFilterChain is smart enough to load a .kra file in 
memory into a KisDoc2 when I request a document as input :)

> But there are plenty of other cases, like
>  - using all the koffice-1.x kwd-to-whatever (e.g. RTF) filters without
> rewriting them to use libkotext stuff (QTextDocument) as input - my
> kpresenter-to-kword filter which, because it works with file input and file
> output, can be used BOTH as "save as kword" in kpresenter and "open a
> kpresenter file" in kword. This wouldn't work if it relied on the
> kpresenter internals since it's not running in the second use case. - more
> generally, in any filter chain, the filters other than the first one need a
> file, or at least XML in memory (QDomDocument) as input.
Don't get me wrong, I totally agree that using internal library isn't 
necesseraly the best solution, it's for each filter we have to think what is 
the better solution. I am just trying to collect information on our filter (I 
don't think I will vexate anyone by telling that the current knowldege on how 
the filters work among active developers is very limited, while it's an 
important part of KOffice), and I was just willing to check that we didn't have 
a problem, I would consider koconverter not being able to convert to/from 
.kra, .png, .tiff, .jpeg as a bug :)

>  - same for koconverter, it needs a file as input, it doesn't dlopen the
> application to let it load the input file :)
Yes it does :) "koconverter test.kra test.png" does that.

-- 
Cyrille Berger

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"><html><head><meta name="qrichtext" \
content="1" /><style type="text/css">p, li { white-space: pre-wrap; \
}</style></head><body style=" font-family:'DejaVu Sans'; font-size:9pt; \
font-weight:400; font-style:normal;">On Tuesday 20 January 2009, David Faure \
wrote:<br> &gt; &gt; how so ? if at the end the filter give something that can be \
saved ? (or<br> &gt; &gt; something that is saved), it should still work right ?<br>
&gt;<br>
&gt; What if the _input_ of a filter is a file on disk? I think you're narrowing<br>
&gt; your thinking to "saving from the app using in-memory structures".<br>
Good point, but yet, KoFilterChain is smart enough to load a .kra file in memory into \
a KisDoc2 when I request a document as input :)<br> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>&gt; But there are plenty of other cases, like<br> &gt;  - \
using all the koffice-1.x kwd-to-whatever (e.g. RTF) filters without<br> &gt; \
rewriting them to use libkotext stuff (QTextDocument) as input - my<br> &gt; \
kpresenter-to-kword filter which, because it works with file input and file<br> &gt; \
output, can be used BOTH as "save as kword" in kpresenter and "open a<br> &gt; \
kpresenter file" in kword. This wouldn't work if it relied on the<br> &gt; kpresenter \
internals since it's not running in the second use case. - more<br> &gt; generally, \
in any filter chain, the filters other than the first one need a<br> &gt; file, or at \
least XML in memory (QDomDocument) as input.<br> Don't get me wrong, I totally agree \
that using internal library isn't necesseraly the best solution, it's for each filter \
we have to think what is the better solution. I am just trying to collect information \
on our filter (I don't think I will vexate anyone by telling that the current \
knowldege on how the filters work among active developers is very limited, while it's \
an important part of KOffice), and I was just willing to check that we didn't have a \
problem, I would consider koconverter not being able to convert to/from .kra, .png, \
.tiff, .jpeg as a bug :)<br> <p style="-qt-paragraph-type:empty; margin-top:0px; \
margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; \
text-indent:0px; -qt-user-state:0;"><br></p>&gt;  - same for koconverter, it needs a \
file as input, it doesn't dlopen the<br> &gt; application to let it load the input \
file :)<br> Yes it does :) "koconverter test.kra test.png" does that.<br>
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"><br></p>-- <br> Cyrille Berger</p></body></html>



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic