[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: win 32 bug fix for kword
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2009-01-12 5:08:07
Message-ID: 200901120608.07532.t.zachmann () zagge ! de
[Download RAW message or body]

On Sunday 11 January 2009, Thomas Zander wrote:
> On Saturday 10. January 2009 00:17:08 Ralf Habacker wrote:
> > Hi,
> > the appended patch fix a seg fault caused by a zero d-pointer,
> > additional it added an assert to catch zero parameter.
>
> Having a zero pointer means the usage of an unitialized pageStyle (the
> empty constructor). Which means the bug is elsewhere.
>
> Do you have a backtrace and/or a way to reproduce?
>
> Having a zero pointer is completely legal (see the implementation of
> isValid()). So your patch is incorrect :)
>
> ps. for those wondering; this class uses an QExplicitlySharedDataPointer so
> d is zero without any initialization needed.

See the bug http://bugs.kde.org/show_bug.cgi?id=180238 which is fixed after 
applying this patch. 

Thorsten
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]