[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Various fixes for textShape
From:       Pierre Stirnweiss <pierre.stirnweiss () t-online ! de>
Date:       2008-12-09 20:34:40
Message-ID: 200812092134.40452.pierre.stirnweiss () t-online ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


As already seen with Thomas, I have committed 5 patches.
They solve various problems on the textShape, mainly related to undo/redo. 
Most appear on the KWord audit on the wiki, should I go and update the page?

the first one deals with the crash on undoing a textShape (frame) creation. The 
undo itself didn't crash. It is when the command was destroyed when a new 
command was made (clearing the redo stack).
	maybe equals to the point : undoing the initial creation of a frame crashes 
kword. in the audit page. let's put it that way, I can't crash KWord anymore 
by undoing the creation of a textShape. If people are still having a crash, 
please contact me.

the second relates to: make undo/redo in text shape work. Undo/redo does not 
work when you select a different shape than the text shape that was modified. of 
the audit page.

the third one is sort of linked to the previous one. when undoing a change on 
a different shape than the one selected, newly type text would be entered in 
the non selected shape (because the cursor was passed to the undo).

the fourth relates to the Font... dialog which didn't work if no selection was 
made. ie: it would not change the font format for subsequently typed in text

the fifth relates to: List editing undo/redo and many others do not work. of 
the audit page. the list editing is still not fixed (currently working on it) 
but the various other were affected by the behavior of keying in "commands". 
Once again, if people find undo that still doesn't work (apart from list 
editing), please ping me.

Pierre

[Attachment #5 (text/html)]

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN" \
"http://www.w3.org/TR/REC-html40/strict.dtd"> <html><head><meta name="qrichtext" \
content="1" /><style type="text/css"> p, li { white-space: pre-wrap; }
</style></head><body style=" font-family:'Sans Serif'; font-size:10pt; \
font-weight:400; font-style:normal;"> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">As already seen with Thomas, I have committed 5 patches.</p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">They solve various problems \
on the textShape, mainly related to undo/redo. Most appear on the KWord audit on the \
wiki, should I go and update the page?</p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">the first one deals with the \
crash on undoing a textShape (frame) creation. The undo itself didn't crash. It is \
when the command was destroyed when a new command was made (clearing the redo \
stack).</p> <p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;">	maybe \
equals to the point : undoing the initial creation of a frame crashes kword. in the \
audit page. let's put it that way, I can't crash KWord anymore by undoing the \
creation of a textShape. If people are still having a crash, please contact me.</p> \
<p style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;"></p> <p style=" margin-top:0px; margin-bottom:0px; \
margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px; \
-qt-user-state:0;">the second relates to: make undo/redo in text shape work. \
Undo/redo does not work when you select a different shape than the text shape that \
was modified. of the audit page.</p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">the third one is sort of \
linked to the previous one. when undoing a change on a different shape than the one \
selected, newly type text would be entered in the non selected shape (because the \
cursor was passed to the undo).</p> <p style="-qt-paragraph-type:empty; \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p style=" \
margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">the fourth relates to the \
Font... dialog which didn't work if no selection was made. ie: it would not change \
the font format for subsequently typed in text</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">the fifth relates to: List \
editing undo/redo and many others do not work. of the audit page. the list editing is \
still not fixed (currently working on it) but the various other were affected by the \
behavior of keying in "commands". Once again, if people find undo that still doesn't \
work (apart from list editing), please ping me.</p> <p \
style="-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; \
margin-right:0px; -qt-block-indent:0; text-indent:0px; -qt-user-state:0;"></p> <p \
style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; \
-qt-block-indent:0; text-indent:0px; -qt-user-state:0;">Pierre</p></body></html>



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic