[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    [PATCH] Fix problem with tabstops in filters/liboofilter/ooutils.cc
From:       Magnus Lundborg <lundborg.magnus () gmail ! com>
Date:       2008-12-01 23:28:56
Message-ID: 49347338.5010606 () gmail ! com
[Download RAW message or body]

I am sorry about my last patch which proved erroneous. I hope this is 
better.

My oowriter files do not contain the prefix ("style") in the tagName. I 
split the checks so that the prefix and the tagName are examined 
separately to avoid a crash.

If someone else has got files to test this it would be good.

Best Regards
/Magnus

["patch.diff" (text/plain)]

Index: filters/liboofilter/ooutils.cc
===================================================================
--- filters/liboofilter/ooutils.cc	(revision 891384)
+++ filters/liboofilter/ooutils.cc	(working copy)
@@ -208,7 +208,8 @@
     for ( KoXmlNode it = tabStops.firstChild(); !it.isNull(); it = it.nextSibling() \
)  {
         KoXmlElement tabStop = it.toElement();
-        Q_ASSERT( tabStop.tagName() == "style:tab-stop" );
+	Q_ASSERT( tabStop.prefix() == "style" );
+	Q_ASSERT( tabStop.tagName() == "tab-stop" );
         QString type = tabStop.attributeNS( ooNS::style, "type", QString() ); // \
left, right, center or char  
         QDomElement elem = parentElement.ownerDocument().createElement( "TABULATOR" \
);



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]