From koffice-devel  Sun Nov 16 21:29:36 2008
From: jaham () gmx ! net
Date: Sun, 16 Nov 2008 21:29:36 +0000
To: koffice-devel
Subject: Re: [PATCH] Selecting image when inserting picture shape
Message-Id: <200811162229.36948.jaham () gmx ! net>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=122687101417995

On Sunday 16 November 2008 21:51:19 Thomas Zander wrote:
> On Sunday 16. November 2008 21:17:12 jaham@gmx.net wrote:
> > The new method returns true by default, so they behave as before. Could
> > you explain more what you think should be ported?
>
> I have not spent a lot of time looking at the usage of this class, so I
> don't know if there are usecases where this introduction of the new
> variable means those widgets should also start returning true, but false
> for the other one.
> Or, like the divine proportion one, it should probably return false here.

I see what you mean. But it would probably only make sense if a shape config 
widget has at least on of the two methods return true, otherwise they would 
never be shown. So those shapes that are shown on shape creation should be 
checked if it makes sense for them to be shown inside the shape properties 
docker.

>
> My question was more based on the idea that we are getting closer to the
> release and thus there will be less user feedback when something unforeseen
> goes out.

Right.

Ciao Jan
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel