[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Selecting image when inserting picture shape
From:       Cyrille Berger <cberger () cberger ! net>
Date:       2008-11-14 22:56:52
Message-ID: 200811142356.52140.cberger () cberger ! net
[Download RAW message or body]

Hi

I am not sure if I understood correctly what you did.
But didn't we say that the dialog only be shown when you first insert the 
image ? And then, when the shape is on the canvas the docker would be used to 
change the image ? Is that what your patch is doing ?

On Friday 14 November 2008, jaham@gmx.net wrote:
> Hi folks...
>
> I took the opportunity to fix a usability which we briefly discussed at the
> last KOffice meeting. This makes it possible to have a file dialog pop up
> when a picture shape is inserted into a document. To not have the file
> dialog shown in the shape properties docker i added a new function
> KoShapeConfigWidgetBase::showOnShapeSelect which controls if a shape config
> widget is shown inside the shape properties docker when the corresponding
> shape is selected.
> This is a proof of concept and can probably be improved, but is imho a lot
> better than what we have now (i.e. insert picture shape, double click the
> shape, click on button in picture tool, choose file).
> Please test and comment on the attached patch.
>
> Ciao Jan



-- 
Cyrille Berger
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]