[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Disabling of tools
From:       Cyrille Berger <cberger () cberger ! net>
Date:       2008-10-12 8:47:39
Message-ID: 200810121047.39527.cberger () cberger ! net
[Download RAW message or body]

On Sunday 12 October 2008, Thomas Zander wrote:
> Morning Cyrille.
>
> On Sunday 12. October 2008 00:41:14 Cyrille Berger wrote:
> > On Saturday 11 October 2008, Thomas Zander wrote:
> > But, we got multiple reports of users
> > being confused by the disappearing tool, especially since karbon freehand
> > tool is above krita's one, they were using it to draw something, then
> > most of the tool disappeared and they don't understand how to get them
> > back. This was one of the main reason behind the toolbox SoU project...
>
> The early versions of krita2 had the selection (default tool) actually
> select layer shapes, so I can fully see why the above happened. Luckely
> boud made this a lot better in recent versions.
> Currently the only way you can loose your tools is if you manually go to
> the layer box and select a shape layer.

Or use the vector freehand tool:
The users that reported the issue were first using the karbon freehand tool 
which creates a shape layer which made the tool disappeared which made them 
think that there is a bug.

Well anyway, it's completely unrelated to the matter at hand, so if you wish 
to discuss this further, I suggest starting a new thread or opening a bug 
report.

> > It's also less flexible,
> > a tool can also be disabled if there is no perspective grid, or no
> > whatever else. While preventing the tool to cheat sounds like a good
> > idea, I somehow think that it is the tool that know best their
> > requirement.
>
> My suggestion to massively disable tools under certain logical
> circumstances is mean to avoid code duplication.
> It doesn't take away from the tools ability to conclude it can't be used at
> this time.  So it won't be less flexible at all, just that more generic
> work will be done without code in each and every tool.

Ok so we would have the setEnabled mechanism in KoTool to disable the tools. 
And a mechanism in KoToolManager that would call KoTool::setEnabled for 
a "massive" disabling/enabling of tools, and that would be connect to a 
change of layer triggered by a signal comming from the shape manager's 
selection ?

> > > 1) actually, you currently just don't see those tools at all. But I
> > > assume thats a bug.
> >
> > I do see all those tools.
>
> If you select a text shape you see the paragraph tool as well as the text
> tool in the toolbox?
> Since I don't see either of those..

Voila http://bugs.kde.org/show_bug.cgi?id=172642 ;)

-- 
Cyrille Berger
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]