[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    [patch] Allow compilation with Qt 4.5
From:       Brad Hards <bradh () frogmouth ! net>
Date:       2008-08-24 7:21:57
Message-ID: 200808241721.58483.bradh () frogmouth ! net
[Download RAW message or body]

I'm trying to build KDE with Qt 4.5 snapshot (originally for a new feature - \
QTextDocumentWriter, but also to see what breaks).

In KOffice, I get this:

/home/bradh/devel/kde-src/koffice/kexi/formeditor/container.cpp:377: error: ISO C++ \
says that these are ambiguous, even though the worst conversion for the first is \
better than the worst  conversion for the second:
/home/bradh/devel/kde-src/koffice/kexi/formeditor/container.cpp:377: note: candidate \
1: operator|(int, unsigned int) <built-in> \
/opt/qt45/include/QtCore/qnamespace.h:1522: note: candidate 2:  QIncompatibleFlag \
                operator|(Qt::MouseButton, int)
/home/bradh/devel/kde-src/koffice/kexi/formeditor/container.cpp:377: warning: \
‘QMouseEvent::QMouseEvent(QEvent::Type, const QPoint&, Qt::ButtonState, int)' is \
deprecated (declared  at /opt/qt45/include/QtGui/qevent.h:102)

I'm not really sure what the original code was doing, so while I do have a patch that \
looks reasonable, I'd like a "sure, fine" level confirmation before committing.

Patch:
--- /home/bradh/devel/kde-src/koffice/kexi/formeditor/container.cpp     (revision \
                850712)
+++ /home/bradh/devel/kde-src/koffice/kexi/formeditor/container.cpp     (working \
copy) @@ -374,7 +374,7 @@
                 return true;
             // we simulate a mouse move event to update screen
             QMouseEvent *mev = new QMouseEvent(QEvent::MouseMove, \
                m_moving->mapFromGlobal(QCursor::pos()), Qt::NoButton,
-                                               Qt::LeftButton | \
Qt::ControlModifier); +                                               Qt::LeftButton, \
Qt::ControlModifier);  eventFilter(m_moving, mev);
             delete mev;
         } else if (kev->key() == FormManager::self()->contextMenuKey()) {

Brad
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]