[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [PATCH] Replace KisVector2D by Eigen
From:       jacob () math ! jussieu ! fr
Date:       2008-08-23 14:32:07
Message-ID: 20080823163207.zwi3rgh008ccowok () mail ! math ! jussieu ! fr
[Download RAW message or body]

Quoting Girish Ramakrishnan <girish@forwardbias.in>:

> A patch that uses std:abs() will most likely not be accepted since Qt
> cannot depend on stl (unless you want to ifdef stl support). However, if
> you provide a patch that implements the specializations stand alone, it
> has a higher probability of being accepted.

That's what I was afraid of. A patch that ifdefs stl support won't be  
very useful as most people (afaik) compile without stl support (my  
understanding is that this is not the default).

I'll see if instead I can make a patch ifdefing GCC and calling the  
low-level builtins directly.

Cheers,
Benoit

>
> Girish
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
>



----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]