--===============1507655240==
Content-Type: multipart/signed;
  boundary="nextPart2185006.T424Af37ZA";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart2185006.T424Af37ZA
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Ooh, cool. :)

Patches look great.

I committed them with only slight adjustments; I fixed some whitespace issu=
es=20
and added a Q_ASSERT(m_currentPage); where you removed the if (m_currentPag=
e)=20
just to make it clear we now depend upon that var never being null :)

Thanks a lot for these!!

On Tuesday 22. July 2008 21:36:09 Tony Wolf wrote:
> here are two small patches to fix 167009 and 167103.
>
> I've tested them (compiling and stressing kword :D) and these two issues
> seems to be gone.
>
> For 167009 I tried to find a way to disable "Edit->Delete Page" if there =
is
> only one page available and to enable it if pageCount is increasing. But
> haven't found a way to do this within KWDocument.

I think the way to do this is to convert KWPageManager into a QObject and l=
et=20
it emit a signal if a page is added/removed.  We can then connect to that i=
n=20
the document and check if the amount of pages is such that we should enable=
=20
the action; like this;

> This code should do the task:
> bool enablePageCount =3D m_document->pageCount > 1;
> actionCollection()->action("delete_page")->setEnabled(enablePageCount);

Thanks for working on bugs in kword!
=2D-=20
Thomas Zander

--nextPart2185006.T424Af37ZA
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQBIhtgqCojCW6H2z/QRAj+eAJ9QZpYMFr6Agi6XYHXnOctvT3k0agCg8gJ3
Lsc4xKCPgueq8nfHwl7mjio=
=EPFv
-----END PGP SIGNATURE-----

--nextPart2185006.T424Af37ZA--

--===============1507655240==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

--===============1507655240==--