[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: koffice
From:       Thomas Zander <zander () kde ! org>
Date:       2008-06-12 8:30:17
Message-ID: 200806121030.17341.zander () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 12. June 2008 09:07:28 Jan Hambrecht wrote:
> In the end i am confident that everything works like before and that
> there are no regressions. And as i understand it, it is important for
> KPresenter which needs this for page backgrounds.

I read the patch this morning, it looks to me that you split QBrush into 3 
classes which have virtual methods for setting and getting data. I'm not sure 
what new features this gives, I'm probably just missing it but all the same I 
would appreciate some API docs for the new classes ;)

I noted some things while reading the diff;
* for refcounting you should consider using QAtomicInt (new in Qt4.4)
* you use QGradient (which is a value based class, and implicitly shared) in 
combination with 'new' and 'delete'. This will give you confusing API and 
cause for bugs.
* We left QBrush in KoShape until now since we need a design to make shapes 
use pigment, your solution uses QGradient and thus is not compatible with 
pigment AFAIK :(
* KoGradientBackground::cloneGradient is private, it should not be in the 
header file but it should be a method on the d-pointer object.

-- 
Thomas Zander

["signature.asc" (application/pgp-signature)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]