[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: time to move on to qt44
From:       Sebastian Sauer <mail () dipe ! org>
Date:       2008-06-05 17:14:44
Message-ID: 200806051914.44927.mail () dipe ! org
[Download RAW message or body]

On Thursday 05 June 2008, Girish Ramakrishnan wrote:
> Thomas Zander wrote:
> > On Tuesday 13. May 2008 15:09:58 Sebastian Sauer wrote:
> >>> I would argue that this is the only correct fix, passing around a
> >>> non-valid block doesn't seem like something Qt should be guarded
> >>> against.
> >>
> >> heh. Actually it's a Qt4.4-workaround since Qt is pretty well protected
> >> against invalid blocks. I tried to reproduce this with some testcases
> >> but failed there.
> >
> > Ok, I took a look and discovered that not the block but the list is a
> > dangling pointer.
> >
> > The KoTextLoader::loadList load list seems to be doing some weirdness
> > that doesn't make sense to me.
> > It uses both the ListStyle and the cursor->createList.
> > This is mixing concept and you should be using only one of those two. 
> > The listStyle is capable of holding various QTextList objects, one for
> > each list-level.  So creating and managing one QTextList object outside
> > of the style to represent the list seems like a bad idea.
> >
> > Why is the createList and addBlock() needed at all?
>
> Yes, not required. I fixed this today.

Fantastic, thank you very much!
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]