[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KoPrintingDialog
From:       "Peter Simonsson" <peter.simonsson () gmail ! com>
Date:       2008-05-31 10:09:10
Message-ID: 9966b3040805310309g23995971mf3a5a8e09e7e81b6 () mail ! gmail ! com
[Download RAW message or body]

2008/5/31 Stefan Nikolaus <stefan.nikolaus@kdemail.net>:
> On Saturday, 31. May 2008 11:23:44 Peter Simonsson wrote:
>> 2008/5/31 Stefan Nikolaus <stefan.nikolaus@kdemail.net>:
>> > Hi,
>> >
>> > may I change the order of method calls in
>> > KoPrintingDialogPrivate::printPage(const QVariant &page).
>> >
>> > Currently, the shape manager prints its shapes first and after that
>> > KoPrintingDialog::printPage(int, QPainter &) is called. This method is
>> > empty and until now only KSpread reimplements it.
>> >
>> > The reason behind this request is, that the cells get printed on top of
>> > the shapes, but it needs to be the other way around.
>>
>> Sounds like it makes sense to me.
>
> Okay, one more thing: the painter saving/restoring looks odd. I do not
> understand that behavior. Attached my proposal how it should work.
>
Yeah your patch looks cleaner.


-- 
LLaP
Peter Simonsson
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]