[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: ODF Testsuite update
From:       Girish Ramakrishnan <girish () forwardbias ! in>
Date:       2008-05-16 10:51:35
Message-ID: 482D66FC.3010607 () forwardbias ! in
[Download RAW message or body]

Hi,
The final outcomes was:
1. There is a bug that has to do with font comparison. The the default 
font on my machine is different from the default font on Pierre's 
machine causing the tests to fail. I will fix this.

2. We have only 1 test case with 33 documents fed in as data. If ALL 
these data succeed, then QTestLib will report 1 pass. If 10 data fail, 
QTestLib will count it as 10 failures. That's the way QTestLib works :-) 
Harald, are you on this list?

3. The expected result is
 >> Totals: 3 passed, 0 failed, 0 skipped
    (initTestCase + finiTestCase are the other two "passed" test cases).

Girish

Pierre wrote:
> Just for fun : replace QVERIFY(documentsEqual) with
> QCOMPARE(documentsEqual, false)...
> Et voila, you have 34 failing tests again and 2 passing...
> and what about QCOMPARE(documentsEqual, true) ?
> 2 passing tests, no failing...
> 
> Happy nightmares everyone :)
> 
> On Fri, May 16, 2008 at 1:21 AM, Sebastian Sauer <mail@dipe.org> wrote:
>> On Friday 16 May 2008, Pierre wrote:
>>> On Wed, May 14, 2008 at 1:56 AM, Sebastian Sauer <mail@dipe.org> wrote:
>>>> On Tuesday 13 May 2008, Girish Ramakrishnan wrote:
>>>>> Thomas told me some of you are doing some refactoring with - Please read
>>>>> the README and the STATUS file (this probably belongs in a Wiki) that I
>>>>> submitted sometime back. The good news is that I svn up'ed and ran the
>>>>> tests just now and they all pass :-)
>>>> for sure they do cause we are pretty aware of the tests and did only
>>>> touched code that was not working anyway to get it working ;)
>>>>
>>>> but I would also like to investigate sooner or later things like e.g.
>>>> http://lists.kde.org/?l=koffice-devel&m=121068865723376&w=2 (which may
>>>> touch things that are covered by the tests already what's pretty good
>>>> since it would allow us to verify that we don't break things) plus we
>>>> should also extend the tests with things that don't work yet but will
>>>> work (hopefully) soon - namely frames, anchors, headers+footers, etc.
>>> I tried the commands written in the README and I got the following result :
>>> Totals: 2 passed, 32 failed, 0 skipped
>> btw;
>>
>>     // this should really be actualFormat.properties() ==
>> expectedFormat.properties()
>> -    bool equal = actualFormat.font() == expectedFormat.font()
>> +    bool equal = true; /*actualFormat.font() == expectedFormat.font()
>>            && actualFormat.font().styleHint() ==
>> expectedFormat.font().styleHint() // test this explicity since font ==
>> ignores it
>>            && actualFormat.foreground() == expectedFormat.foreground()
>>            && actualFormat.background() == expectedFormat.background()
>> @@ -113,7 +113,7 @@
>>            && actualFormat.property(KoCharacterStyle::Language).toString()
>>                   ==
>> expectedFormat.property(KoCharacterStyle::Language).toString()
>>            && actualFormat.verticalAlignment() ==
>> expectedFormat.verticalAlignment(); // FIXME: Compare other properties
>> -
>> +*/
>>     if (!equal)
>>         qDebug() << "compareFragment: property mismatch at " <<
>> actualFragment.text();
>>
>> results in;
>> Totals: 3 passed, 0 failed, 0 skipped
>> rather then;
>> Totals: 2 passed, 32 failed, 0 skipped
>> _______________________________________________
>> koffice-devel mailing list
>> koffice-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/koffice-devel
>>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]