[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: pigment compile
From:       Roopesh Chander <rheupeiti () gmail ! com>
Date:       2008-03-29 9:37:15
Message-ID: 47EE0AFB.7070400 () forwardbias ! in
[Download RAW message or body]

The s/not/!/-and-the-like problems exist in these files:
M      libs/pigment/KoColorConversionSystem.cpp
M      libs/pigment/KoColorSpaceEngine.cpp
M      libs/pigment/tests/CCSGraph.cpp
M      libs/pigment/KoColorConversionSystem_p.h

There's an ongoing discussion in this mailing list (subj: 
koffice/libs/pigment) on this on how to fix this - I'm however yet to 
understand why that's a bone of contention :).

This is the problem in my understanding:
There are definitions in libs/pigment/pigment_export.h that tell the 
compiler that 'not' is actually '!' and so on (introduced in r790504), 
but moc creation (eg. KoColorSet.moc, KoColorSpaceRegistry.moc) doesn't 
like those lines, so have had to remove them. But once we remove them, 
the 'not's and 'and's and 'or's in code break during compilation, so 
gotta change them back to the mundane ! and && and ||. Once I did that 
koffice compiles fine.

I have attached the patch of my changes in (over r790663) if that's of 
any help.

I see that pigment_export.h has been changed afterwards (r790968) in an 
attempt to include those definitions only for windows, but, if I'm 
right, any code that uses 'and' instead of '&&' will not (or '!') build 
on linux. So I think pigment_export.h should not have these definitions 
at all, for any platform.

roop.

Thomas Zander wrote:
> On my kubuntu gutsy machine I can no longer compile pigment.
> I get things like;
> 
> [ 60%] Building CXX object \
>                 libs/pigment/CMakeFiles/pigmentcms.dir/KoColorConversionSystem.o
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h: In member \
>                 function ‘void KoColorConversionSystem::Node::init(const \
>                 KoColorSpaceFactory*)’:
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:25: error: \
>                 ‘not’ was not declared in this scope
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:25: error: \
>                 expected `)' before ‘isInitialized’
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:25: error: \
>                 expected `)' before ‘;’ token
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:25: error: \
>                 expected `)' before ‘;’ token
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:35: error: \
>                 expected `)' before ‘or’
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h: In member \
>                 function ‘void KoColorConversionSystem::Node::init(const \
>                 KoColorSpaceEngine*)’:
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:40: error: \
>                 ‘not’ was not declared in this scope
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:40: error: \
>                 expected `)' before ‘isInitialized’
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:40: error: \
>                 expected `)' before ‘;’ token
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem_p.h:40: error: \
> expected `)' before ‘;’ token (and many more)
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem.cpp:173: error: \
>                 'not' was not declared in this scope
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem.cpp:173: error: \
>                 expected `)' before 'v'
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem.cpp:178: error: \
>                 expected `)' before 'and'
> /home/zander/work/kde/koffice/libs/pigment/KoColorConversionSystem.cpp:182: error: \
> expected `)' before 'and' (and many more)
> 
> Suggestions?
> I did a revert of commit 790968 locally which seems to fix the issue for me.
> Should I commit?
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel


["koffice_use_bang_not_not.patch.gz" (application/x-gzip)]

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]