[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] exp0rt method rename
From:       Sebastian Sauer <mail () dipe ! org>
Date:       2008-03-08 23:51:45
Message-ID: 200803090051.45960.mail () dipe ! org
[Download RAW message or body]

On Saturday 08 March 2008, Kevin Krammer wrote:
> the attached patch gets rid of the IMHO rather ugly "leet speak" exp0rt()
> name by changing the method name to exportDocument()
> Also changes import to importDocument() for consistency.
>
> Might not have caught all occurencies of import() since I don't have all
> the optional libraries for certain plugins installed.

Guess it's really not needed to pre-review each patch, specialy since your 
patches normaly rock anyway ;) So, probably just commit and let others 
post-review them if they have such a desire?

Well, just /my 2 cent view on it.
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]